Skip to content

Fix error in zsh completion script for docker exec#751

Merged
thaJeztah merged 1 commit into
docker:masterfrom
ktrysmt:fix/zsh-completions
Dec 14, 2017
Merged

Fix error in zsh completion script for docker exec#751
thaJeztah merged 1 commit into
docker:masterfrom
ktrysmt:fix/zsh-completions

Conversation

@ktrysmt
Copy link
Copy Markdown
Contributor

@ktrysmt ktrysmt commented Dec 13, 2017

fixes #750

- What I did
Fix the bug of docker exec at zsh completions.

- How I did it
add only one character.

- How to verify it
Visually?

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@GordonTheTurtle
Copy link
Copy Markdown

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "fix/zsh-completions" git@github.com:ktrysmt/cli.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@ktrysmt
Copy link
Copy Markdown
Contributor Author

ktrysmt commented Dec 13, 2017

Excuse me, I will sign it.

Signed-off-by: Kotaro Yoshimatsu <kotaro.yoshimatsu@gmail.com>
@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 13, 2017

Codecov Report

Merging #751 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #751      +/-   ##
==========================================
- Coverage   53.45%   53.44%   -0.01%     
==========================================
  Files         218      218              
  Lines       14613    14613              
==========================================
- Hits         7811     7810       -1     
- Misses       6321     6322       +1     
  Partials      481      481

Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@thaJeztah thaJeztah changed the title Fixed #750 Fix error in zsh completion script for docker exec Dec 14, 2017
Copy link
Copy Markdown
Contributor

@dnephin dnephin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit ee3ffd6 into docker:master Dec 14, 2017
@GordonTheTurtle GordonTheTurtle added this to the 18.01.0 milestone Dec 14, 2017
nobiit pushed a commit to nobidev/docker-cli that referenced this pull request Nov 19, 2025
Fix error in zsh completion script for docker exec
Upstream-commit: ee3ffd6
Component: cli
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The bug of docker exec at zsh completions.

5 participants